Rename port methods:

sendBlockSizeQuery() -> peerBlockSize()
recvBlockSizeQuery() -> deviceBlockSize()
After seeing how this gets used in practice, the
send/recv*Query names just don't make a lot of sense.

dev/io_device.cc:
mem/port.cc:
    sendBlockSizeQuery() -> peerBlockSize()
mem/port.hh:
    sendBlockSizeQuery() -> peerBlockSize()
    recvBlockSizeQuery() -> deviceBlockSize()

--HG--
extra : convert_revision : e96349fb443979b85899a5248bd7cd8665e23ef0
This commit is contained in:
Steve Reinhardt 2006-02-21 12:20:02 -05:00
parent 8a753f6ae2
commit 00264ff1b8
3 changed files with 9 additions and 5 deletions

View file

@ -98,7 +98,8 @@ DmaPort::dmaAction(Memory::Command cmd, DmaPort port, Addr addr, int size,
completionEvent = event;
for (ChunkGenerator gen(addr, size, sendBlockSizeQuery()); !gen.done(); gen.next()) {
for (ChunkGenerator gen(addr, size, peerBlockSize());
!gen.done(); gen.next()) {
Packet *pkt = new Packet(basePkt);
Request *req = new Request(baseReq);
pkt->addr = gen.addr();

View file

@ -41,8 +41,8 @@ Port::blobHelper(Addr addr, uint8_t *p, int size, Command cmd)
pkt.req = &rqst;
pkt.cmd = cmd;
for (ChunkGenerator gen(addr, size, sendBlockSizeQuery()); !gen.done(); gen.next())
{
for (ChunkGenerator gen(addr, size, peerBlockSize());
!gen.done(); gen.next()) {
pkt.addr = rqst.paddr = gen.addr();
pkt.size = rqst.size = gen.size();
pkt.data = p;

View file

@ -86,6 +86,9 @@ class Port
protected:
/** These functions are protected because they should only be
* called by a peer port, never directly by any outside object. */
/** Called to recive a timing call from the peer port. */
virtual bool recvTiming(Packet &pkt) = 0;
@ -109,7 +112,7 @@ class Port
this function to be called, a DMA interface doesn't really have a
block size, so it is defaulted to a panic.
*/
virtual int recvBlockSizeQuery() { panic("??"); }
virtual int deviceBlockSize() { panic("??"); }
/** The peer port is requesting us to reply with a list of the ranges we
are responsible for.
@ -164,7 +167,7 @@ class Port
/** Called by the associated device if it wishes to find out the blocksize
of the device on attached to the peer port.
*/
int sendBlockSizeQuery() { return peer->recvBlockSizeQuery(); }
int peerBlockSize() { return peer->deviceBlockSize(); }
/** Called by the associated device if it wishes to find out the address
ranges connected to the peer ports devices.