2012-03-22 11:36:27 +01:00
|
|
|
/*
|
|
|
|
* Copyright (c) 2012 ARM Limited
|
|
|
|
* All rights reserved.
|
|
|
|
*
|
|
|
|
* The license below extends only to copyright in the software and shall
|
|
|
|
* not be construed as granting a license to any other intellectual
|
|
|
|
* property including but not limited to intellectual property relating
|
|
|
|
* to a hardware implementation of the functionality of the software
|
|
|
|
* licensed hereunder. You may use the software subject to the license
|
|
|
|
* terms below provided that you ensure that this notice is replicated
|
|
|
|
* unmodified and in its entirety in all distributions of the software,
|
|
|
|
* modified or unmodified, in source code or in binary form.
|
|
|
|
*
|
|
|
|
* Copyright (c) 2006 The Regents of The University of Michigan
|
|
|
|
* All rights reserved.
|
|
|
|
*
|
|
|
|
* Redistribution and use in source and binary forms, with or without
|
|
|
|
* modification, are permitted provided that the following conditions are
|
|
|
|
* met: redistributions of source code must retain the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer;
|
|
|
|
* redistributions in binary form must reproduce the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
|
|
* documentation and/or other materials provided with the distribution;
|
|
|
|
* neither the name of the copyright holders nor the names of its
|
|
|
|
* contributors may be used to endorse or promote products derived from
|
|
|
|
* this software without specific prior written permission.
|
|
|
|
*
|
|
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
*
|
|
|
|
* Authors: Ali Saidi
|
|
|
|
* Andreas Hansson
|
|
|
|
*/
|
|
|
|
|
2012-11-16 17:27:47 +01:00
|
|
|
#include "base/trace.hh"
|
2012-08-15 16:38:08 +02:00
|
|
|
#include "debug/Drain.hh"
|
2012-03-22 11:36:27 +01:00
|
|
|
#include "debug/PacketQueue.hh"
|
|
|
|
#include "mem/packet_queue.hh"
|
|
|
|
|
|
|
|
using namespace std;
|
|
|
|
|
MEM: Separate requests and responses for timing accesses
This patch moves send/recvTiming and send/recvTimingSnoop from the
Port base class to the MasterPort and SlavePort, and also splits them
into separate member functions for requests and responses:
send/recvTimingReq, send/recvTimingResp, and send/recvTimingSnoopReq,
send/recvTimingSnoopResp. A master port sends requests and receives
responses, and also receives snoop requests and sends snoop
responses. A slave port has the reciprocal behaviour as it receives
requests and sends responses, and sends snoop requests and receives
snoop responses.
For all MemObjects that have only master ports or slave ports (but not
both), e.g. a CPU, or a PIO device, this patch merely adds more
clarity to what kind of access is taking place. For example, a CPU
port used to call sendTiming, and will now call
sendTimingReq. Similarly, a response previously came back through
recvTiming, which is now recvTimingResp. For the modules that have
both master and slave ports, e.g. the bus, the behaviour was
previously relying on branches based on pkt->isRequest(), and this is
now replaced with a direct call to the apprioriate member function
depending on the type of access. Please note that send/recvRetry is
still shared by all the timing accessors and remains in the Port base
class for now (to maintain the current bus functionality and avoid
changing the statistics of all regressions).
The packet queue is split into a MasterPort and SlavePort version to
facilitate the use of the new timing accessors. All uses of the
PacketQueue are updated accordingly.
With this patch, the type of packet (request or response) is now well
defined for each type of access, and asserts on pkt->isRequest() and
pkt->isResponse() are now moved to the appropriate send member
functions. It is also worth noting that sendTimingSnoopReq no longer
returns a boolean, as the semantics do not alow snoop requests to be
rejected or stalled. All these assumptions are now excplicitly part of
the port interface itself.
2012-05-01 19:40:42 +02:00
|
|
|
PacketQueue::PacketQueue(EventManager& _em, const std::string& _label)
|
2012-11-02 17:32:01 +01:00
|
|
|
: em(_em), sendEvent(this), drainManager(NULL), label(_label),
|
2012-03-22 11:36:27 +01:00
|
|
|
waitingOnRetry(false)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
PacketQueue::~PacketQueue()
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
PacketQueue::retry()
|
|
|
|
{
|
|
|
|
DPRINTF(PacketQueue, "Queue %s received retry\n", name());
|
|
|
|
assert(waitingOnRetry);
|
|
|
|
sendDeferredPacket();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool
|
|
|
|
PacketQueue::checkFunctional(PacketPtr pkt)
|
|
|
|
{
|
|
|
|
pkt->pushLabel(label);
|
|
|
|
|
|
|
|
DeferredPacketIterator i = transmitList.begin();
|
|
|
|
DeferredPacketIterator end = transmitList.end();
|
|
|
|
bool found = false;
|
|
|
|
|
|
|
|
while (!found && i != end) {
|
|
|
|
// If the buffered packet contains data, and it overlaps the
|
|
|
|
// current packet, then update data
|
|
|
|
found = pkt->checkFunctional(i->pkt);
|
|
|
|
++i;
|
|
|
|
}
|
|
|
|
|
|
|
|
pkt->popLabel();
|
|
|
|
|
|
|
|
return found;
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
PacketQueue::schedSendEvent(Tick when)
|
|
|
|
{
|
|
|
|
// if we are waiting on a retry, do not schedule a send event, and
|
|
|
|
// instead rely on retry being called
|
|
|
|
if (waitingOnRetry) {
|
|
|
|
assert(!sendEvent.scheduled());
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!sendEvent.scheduled()) {
|
|
|
|
em.schedule(&sendEvent, when);
|
|
|
|
} else if (sendEvent.when() > when) {
|
|
|
|
em.reschedule(&sendEvent, when);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
MEM: Separate snoops and normal memory requests/responses
This patch introduces port access methods that separates snoop
request/responses from normal memory request/responses. The
differentiation is made for functional, atomic and timing accesses and
builds on the introduction of master and slave ports.
Before the introduction of this patch, the packets belonging to the
different phases of the protocol (request -> [forwarded snoop request
-> snoop response]* -> response) all use the same port access
functions, even though the snoop packets flow in the opposite
direction to the normal packet. That is, a coherent master sends
normal request and receives responses, but receives snoop requests and
sends snoop responses (vice versa for the slave). These two distinct
phases now use different access functions, as described below.
Starting with the functional access, a master sends a request to a
slave through sendFunctional, and the request packet is turned into a
response before the call returns. In a system without cache coherence,
this is all that is needed from the functional interface. For the
cache-coherent scenario, a slave also sends snoop requests to coherent
masters through sendFunctionalSnoop, with responses returned within
the same packet pointer. This is currently used by the bus and caches,
and the LSQ of the O3 CPU. The send/recvFunctional and
send/recvFunctionalSnoop are moved from the Port super class to the
appropriate subclass.
Atomic accesses follow the same flow as functional accesses, with
request being sent from master to slave through sendAtomic. In the
case of cache-coherent ports, a slave can send snoop requests to a
master through sendAtomicSnoop. Just as for the functional access
methods, the atomic send and receive member functions are moved to the
appropriate subclasses.
The timing access methods are different from the functional and atomic
in that requests and responses are separated in time and
send/recvTiming are used for both directions. Hence, a master uses
sendTiming to send a request to a slave, and a slave uses sendTiming
to send a response back to a master, at a later point in time. Snoop
requests and responses travel in the opposite direction, similar to
what happens in functional and atomic accesses. With the introduction
of this patch, it is possible to determine the direction of packets in
the bus, and no longer necessary to look for both a master and a slave
port with the requested port id.
In contrast to the normal recvFunctional, recvAtomic and recvTiming
that are pure virtual functions, the recvFunctionalSnoop,
recvAtomicSnoop and recvTimingSnoop have a default implementation that
calls panic. This is to allow non-coherent master and slave ports to
not implement these functions.
2012-04-14 11:45:07 +02:00
|
|
|
PacketQueue::schedSendTiming(PacketPtr pkt, Tick when, bool send_as_snoop)
|
2012-03-22 11:36:27 +01:00
|
|
|
{
|
2013-04-22 19:20:33 +02:00
|
|
|
DPRINTF(PacketQueue, "%s for %s address %x size %d\n", __func__,
|
|
|
|
pkt->cmdString(), pkt->getAddr(), pkt->getSize());
|
2012-08-21 11:49:24 +02:00
|
|
|
// we can still send a packet before the end of this tick
|
|
|
|
assert(when >= curTick());
|
2012-03-22 11:36:27 +01:00
|
|
|
|
2012-08-22 17:39:56 +02:00
|
|
|
// express snoops should never be queued
|
|
|
|
assert(!pkt->isExpressSnoop());
|
|
|
|
|
2013-01-07 19:05:35 +01:00
|
|
|
// add a very basic sanity check on the port to ensure the
|
|
|
|
// invisible buffer is not growing beyond reasonable limits
|
|
|
|
if (transmitList.size() > 100) {
|
|
|
|
panic("Packet queue %s has grown beyond 100 packets\n",
|
|
|
|
name());
|
|
|
|
}
|
|
|
|
|
2012-03-22 11:36:27 +01:00
|
|
|
// nothing on the list, or earlier than current front element,
|
|
|
|
// schedule an event
|
|
|
|
if (transmitList.empty() || when < transmitList.front().tick) {
|
|
|
|
// note that currently we ignore a potentially outstanding retry
|
|
|
|
// and could in theory put a new packet at the head of the
|
|
|
|
// transmit list before retrying the existing packet
|
MEM: Separate snoops and normal memory requests/responses
This patch introduces port access methods that separates snoop
request/responses from normal memory request/responses. The
differentiation is made for functional, atomic and timing accesses and
builds on the introduction of master and slave ports.
Before the introduction of this patch, the packets belonging to the
different phases of the protocol (request -> [forwarded snoop request
-> snoop response]* -> response) all use the same port access
functions, even though the snoop packets flow in the opposite
direction to the normal packet. That is, a coherent master sends
normal request and receives responses, but receives snoop requests and
sends snoop responses (vice versa for the slave). These two distinct
phases now use different access functions, as described below.
Starting with the functional access, a master sends a request to a
slave through sendFunctional, and the request packet is turned into a
response before the call returns. In a system without cache coherence,
this is all that is needed from the functional interface. For the
cache-coherent scenario, a slave also sends snoop requests to coherent
masters through sendFunctionalSnoop, with responses returned within
the same packet pointer. This is currently used by the bus and caches,
and the LSQ of the O3 CPU. The send/recvFunctional and
send/recvFunctionalSnoop are moved from the Port super class to the
appropriate subclass.
Atomic accesses follow the same flow as functional accesses, with
request being sent from master to slave through sendAtomic. In the
case of cache-coherent ports, a slave can send snoop requests to a
master through sendAtomicSnoop. Just as for the functional access
methods, the atomic send and receive member functions are moved to the
appropriate subclasses.
The timing access methods are different from the functional and atomic
in that requests and responses are separated in time and
send/recvTiming are used for both directions. Hence, a master uses
sendTiming to send a request to a slave, and a slave uses sendTiming
to send a response back to a master, at a later point in time. Snoop
requests and responses travel in the opposite direction, similar to
what happens in functional and atomic accesses. With the introduction
of this patch, it is possible to determine the direction of packets in
the bus, and no longer necessary to look for both a master and a slave
port with the requested port id.
In contrast to the normal recvFunctional, recvAtomic and recvTiming
that are pure virtual functions, the recvFunctionalSnoop,
recvAtomicSnoop and recvTimingSnoop have a default implementation that
calls panic. This is to allow non-coherent master and slave ports to
not implement these functions.
2012-04-14 11:45:07 +02:00
|
|
|
transmitList.push_front(DeferredPacket(when, pkt, send_as_snoop));
|
2012-03-22 11:36:27 +01:00
|
|
|
schedSendEvent(when);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// list is non-empty and this belongs at the end
|
|
|
|
if (when >= transmitList.back().tick) {
|
MEM: Separate snoops and normal memory requests/responses
This patch introduces port access methods that separates snoop
request/responses from normal memory request/responses. The
differentiation is made for functional, atomic and timing accesses and
builds on the introduction of master and slave ports.
Before the introduction of this patch, the packets belonging to the
different phases of the protocol (request -> [forwarded snoop request
-> snoop response]* -> response) all use the same port access
functions, even though the snoop packets flow in the opposite
direction to the normal packet. That is, a coherent master sends
normal request and receives responses, but receives snoop requests and
sends snoop responses (vice versa for the slave). These two distinct
phases now use different access functions, as described below.
Starting with the functional access, a master sends a request to a
slave through sendFunctional, and the request packet is turned into a
response before the call returns. In a system without cache coherence,
this is all that is needed from the functional interface. For the
cache-coherent scenario, a slave also sends snoop requests to coherent
masters through sendFunctionalSnoop, with responses returned within
the same packet pointer. This is currently used by the bus and caches,
and the LSQ of the O3 CPU. The send/recvFunctional and
send/recvFunctionalSnoop are moved from the Port super class to the
appropriate subclass.
Atomic accesses follow the same flow as functional accesses, with
request being sent from master to slave through sendAtomic. In the
case of cache-coherent ports, a slave can send snoop requests to a
master through sendAtomicSnoop. Just as for the functional access
methods, the atomic send and receive member functions are moved to the
appropriate subclasses.
The timing access methods are different from the functional and atomic
in that requests and responses are separated in time and
send/recvTiming are used for both directions. Hence, a master uses
sendTiming to send a request to a slave, and a slave uses sendTiming
to send a response back to a master, at a later point in time. Snoop
requests and responses travel in the opposite direction, similar to
what happens in functional and atomic accesses. With the introduction
of this patch, it is possible to determine the direction of packets in
the bus, and no longer necessary to look for both a master and a slave
port with the requested port id.
In contrast to the normal recvFunctional, recvAtomic and recvTiming
that are pure virtual functions, the recvFunctionalSnoop,
recvAtomicSnoop and recvTimingSnoop have a default implementation that
calls panic. This is to allow non-coherent master and slave ports to
not implement these functions.
2012-04-14 11:45:07 +02:00
|
|
|
transmitList.push_back(DeferredPacket(when, pkt, send_as_snoop));
|
2012-03-22 11:36:27 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// this belongs in the middle somewhere, insertion sort
|
|
|
|
DeferredPacketIterator i = transmitList.begin();
|
|
|
|
++i; // already checked for insertion at front
|
|
|
|
while (i != transmitList.end() && when >= i->tick)
|
|
|
|
++i;
|
MEM: Separate snoops and normal memory requests/responses
This patch introduces port access methods that separates snoop
request/responses from normal memory request/responses. The
differentiation is made for functional, atomic and timing accesses and
builds on the introduction of master and slave ports.
Before the introduction of this patch, the packets belonging to the
different phases of the protocol (request -> [forwarded snoop request
-> snoop response]* -> response) all use the same port access
functions, even though the snoop packets flow in the opposite
direction to the normal packet. That is, a coherent master sends
normal request and receives responses, but receives snoop requests and
sends snoop responses (vice versa for the slave). These two distinct
phases now use different access functions, as described below.
Starting with the functional access, a master sends a request to a
slave through sendFunctional, and the request packet is turned into a
response before the call returns. In a system without cache coherence,
this is all that is needed from the functional interface. For the
cache-coherent scenario, a slave also sends snoop requests to coherent
masters through sendFunctionalSnoop, with responses returned within
the same packet pointer. This is currently used by the bus and caches,
and the LSQ of the O3 CPU. The send/recvFunctional and
send/recvFunctionalSnoop are moved from the Port super class to the
appropriate subclass.
Atomic accesses follow the same flow as functional accesses, with
request being sent from master to slave through sendAtomic. In the
case of cache-coherent ports, a slave can send snoop requests to a
master through sendAtomicSnoop. Just as for the functional access
methods, the atomic send and receive member functions are moved to the
appropriate subclasses.
The timing access methods are different from the functional and atomic
in that requests and responses are separated in time and
send/recvTiming are used for both directions. Hence, a master uses
sendTiming to send a request to a slave, and a slave uses sendTiming
to send a response back to a master, at a later point in time. Snoop
requests and responses travel in the opposite direction, similar to
what happens in functional and atomic accesses. With the introduction
of this patch, it is possible to determine the direction of packets in
the bus, and no longer necessary to look for both a master and a slave
port with the requested port id.
In contrast to the normal recvFunctional, recvAtomic and recvTiming
that are pure virtual functions, the recvFunctionalSnoop,
recvAtomicSnoop and recvTimingSnoop have a default implementation that
calls panic. This is to allow non-coherent master and slave ports to
not implement these functions.
2012-04-14 11:45:07 +02:00
|
|
|
transmitList.insert(i, DeferredPacket(when, pkt, send_as_snoop));
|
2012-03-22 11:36:27 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void PacketQueue::trySendTiming()
|
|
|
|
{
|
|
|
|
assert(deferredPacketReady());
|
|
|
|
|
|
|
|
// take the next packet off the list here, as we might return to
|
|
|
|
// ourselves through the sendTiming call below
|
|
|
|
DeferredPacket dp = transmitList.front();
|
|
|
|
transmitList.pop_front();
|
|
|
|
|
MEM: Separate requests and responses for timing accesses
This patch moves send/recvTiming and send/recvTimingSnoop from the
Port base class to the MasterPort and SlavePort, and also splits them
into separate member functions for requests and responses:
send/recvTimingReq, send/recvTimingResp, and send/recvTimingSnoopReq,
send/recvTimingSnoopResp. A master port sends requests and receives
responses, and also receives snoop requests and sends snoop
responses. A slave port has the reciprocal behaviour as it receives
requests and sends responses, and sends snoop requests and receives
snoop responses.
For all MemObjects that have only master ports or slave ports (but not
both), e.g. a CPU, or a PIO device, this patch merely adds more
clarity to what kind of access is taking place. For example, a CPU
port used to call sendTiming, and will now call
sendTimingReq. Similarly, a response previously came back through
recvTiming, which is now recvTimingResp. For the modules that have
both master and slave ports, e.g. the bus, the behaviour was
previously relying on branches based on pkt->isRequest(), and this is
now replaced with a direct call to the apprioriate member function
depending on the type of access. Please note that send/recvRetry is
still shared by all the timing accessors and remains in the Port base
class for now (to maintain the current bus functionality and avoid
changing the statistics of all regressions).
The packet queue is split into a MasterPort and SlavePort version to
facilitate the use of the new timing accessors. All uses of the
PacketQueue are updated accordingly.
With this patch, the type of packet (request or response) is now well
defined for each type of access, and asserts on pkt->isRequest() and
pkt->isResponse() are now moved to the appropriate send member
functions. It is also worth noting that sendTimingSnoopReq no longer
returns a boolean, as the semantics do not alow snoop requests to be
rejected or stalled. All these assumptions are now excplicitly part of
the port interface itself.
2012-05-01 19:40:42 +02:00
|
|
|
// use the appropriate implementation of sendTiming based on the
|
|
|
|
// type of port associated with the queue, and whether the packet
|
|
|
|
// is to be sent as a snoop or not
|
|
|
|
waitingOnRetry = !sendTiming(dp.pkt, dp.sendAsSnoop);
|
2012-03-22 11:36:27 +01:00
|
|
|
|
|
|
|
if (waitingOnRetry) {
|
|
|
|
// put the packet back at the front of the list (packet should
|
|
|
|
// not have changed since it wasn't accepted)
|
|
|
|
assert(!sendEvent.scheduled());
|
|
|
|
transmitList.push_front(dp);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
PacketQueue::scheduleSend(Tick time)
|
|
|
|
{
|
|
|
|
// the next ready time is either determined by the next deferred packet,
|
|
|
|
// or in the cache through the MSHR ready time
|
|
|
|
Tick nextReady = std::min(deferredPacketReadyTime(), time);
|
|
|
|
|
|
|
|
if (nextReady != MaxTick) {
|
|
|
|
// if the sendTiming caused someone else to call our
|
|
|
|
// recvTiming we could already have an event scheduled, check
|
|
|
|
if (!sendEvent.scheduled())
|
|
|
|
em.schedule(&sendEvent, std::max(nextReady, curTick() + 1));
|
|
|
|
} else {
|
|
|
|
// no more to send, so if we're draining, we may be done
|
2012-11-02 17:32:01 +01:00
|
|
|
if (drainManager && transmitList.empty() && !sendEvent.scheduled()) {
|
2012-08-15 16:38:08 +02:00
|
|
|
DPRINTF(Drain, "PacketQueue done draining,"
|
|
|
|
"processing drain event\n");
|
2012-11-02 17:32:01 +01:00
|
|
|
drainManager->signalDrainDone();
|
|
|
|
drainManager = NULL;
|
2012-03-22 11:36:27 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
PacketQueue::sendDeferredPacket()
|
|
|
|
{
|
|
|
|
// try to send what is on the list, this will set waitingOnRetry
|
|
|
|
// accordingly
|
|
|
|
trySendTiming();
|
|
|
|
|
|
|
|
// if we succeeded and are not waiting for a retry, schedule the
|
|
|
|
// next send
|
|
|
|
if (!waitingOnRetry) {
|
|
|
|
scheduleSend();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
PacketQueue::processSendEvent()
|
|
|
|
{
|
|
|
|
assert(!waitingOnRetry);
|
|
|
|
sendDeferredPacket();
|
|
|
|
}
|
|
|
|
|
|
|
|
unsigned int
|
2012-11-02 17:32:01 +01:00
|
|
|
PacketQueue::drain(DrainManager *dm)
|
2012-03-22 11:36:27 +01:00
|
|
|
{
|
|
|
|
if (transmitList.empty() && !sendEvent.scheduled())
|
|
|
|
return 0;
|
2012-08-15 16:38:08 +02:00
|
|
|
DPRINTF(Drain, "PacketQueue not drained\n");
|
2012-11-02 17:32:01 +01:00
|
|
|
drainManager = dm;
|
2012-03-22 11:36:27 +01:00
|
|
|
return 1;
|
|
|
|
}
|
MEM: Separate requests and responses for timing accesses
This patch moves send/recvTiming and send/recvTimingSnoop from the
Port base class to the MasterPort and SlavePort, and also splits them
into separate member functions for requests and responses:
send/recvTimingReq, send/recvTimingResp, and send/recvTimingSnoopReq,
send/recvTimingSnoopResp. A master port sends requests and receives
responses, and also receives snoop requests and sends snoop
responses. A slave port has the reciprocal behaviour as it receives
requests and sends responses, and sends snoop requests and receives
snoop responses.
For all MemObjects that have only master ports or slave ports (but not
both), e.g. a CPU, or a PIO device, this patch merely adds more
clarity to what kind of access is taking place. For example, a CPU
port used to call sendTiming, and will now call
sendTimingReq. Similarly, a response previously came back through
recvTiming, which is now recvTimingResp. For the modules that have
both master and slave ports, e.g. the bus, the behaviour was
previously relying on branches based on pkt->isRequest(), and this is
now replaced with a direct call to the apprioriate member function
depending on the type of access. Please note that send/recvRetry is
still shared by all the timing accessors and remains in the Port base
class for now (to maintain the current bus functionality and avoid
changing the statistics of all regressions).
The packet queue is split into a MasterPort and SlavePort version to
facilitate the use of the new timing accessors. All uses of the
PacketQueue are updated accordingly.
With this patch, the type of packet (request or response) is now well
defined for each type of access, and asserts on pkt->isRequest() and
pkt->isResponse() are now moved to the appropriate send member
functions. It is also worth noting that sendTimingSnoopReq no longer
returns a boolean, as the semantics do not alow snoop requests to be
rejected or stalled. All these assumptions are now excplicitly part of
the port interface itself.
2012-05-01 19:40:42 +02:00
|
|
|
|
|
|
|
MasterPacketQueue::MasterPacketQueue(EventManager& _em, MasterPort& _masterPort,
|
|
|
|
const std::string _label)
|
|
|
|
: PacketQueue(_em, _label), masterPort(_masterPort)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
bool
|
|
|
|
MasterPacketQueue::sendTiming(PacketPtr pkt, bool send_as_snoop)
|
|
|
|
{
|
|
|
|
// attempt to send the packet and return according to the outcome
|
|
|
|
if (!send_as_snoop)
|
|
|
|
return masterPort.sendTimingReq(pkt);
|
|
|
|
else
|
|
|
|
return masterPort.sendTimingSnoopResp(pkt);
|
|
|
|
}
|
|
|
|
|
|
|
|
SlavePacketQueue::SlavePacketQueue(EventManager& _em, SlavePort& _slavePort,
|
|
|
|
const std::string _label)
|
|
|
|
: PacketQueue(_em, _label), slavePort(_slavePort)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
bool
|
|
|
|
SlavePacketQueue::sendTiming(PacketPtr pkt, bool send_as_snoop)
|
|
|
|
{
|
|
|
|
// we should never have queued snoop requests
|
|
|
|
assert(!send_as_snoop);
|
|
|
|
return slavePort.sendTimingResp(pkt);
|
|
|
|
}
|